|
Monday, August 05, 2002 |
|
Several days I ago I misunderstood an exchange I had with Mark Paschal about fixing permalinks in Kit. I did download his latest release and found that permalinks now work in Kit's search results - unless the post is a category-only post. Kit does not display a permalink for these. [You can skip this] The problem is the result of Kit using a routine within Radio to determine the URL for a particular post (getUrlForPost). However, this routine expects the caller to specify whether the post belongs to a particular category or not. Kit's search overlooks category information for a post; the upshot is that category-only posts do not get a permalink. Today I added a couple of lines of code to Mark's KitSuite.renderWeblogItem routine to fix this small oversight. You can download the code and try it out. I am hoping Mark will incorporate this into Kit when he has time to do so. Note that this only works for Kit 1.1.7. |
|
A couple of weeks ago I was thinking about ways to improve our code reviews. Lydia has given me a good idea. Rather than trying to review every line of code, maybe I should just be doing spot checks. This idea led to some more thought and I think I have come up with a better approach for doing design and code reviews in ICT. Here is my proposal. Since our project leads are responsible for the design effort of every project, I think it makes sense for them to take responsibility for performing code reviews. Their purpose will be to ensure that our coding standards are met, that the code implements their design, and that the code performs per client expectations. Since the project leads are intimately familiar with each project, they are in an ideal position to perform these code reviews. While I think it unneccessary, based on what I have seen, the Architects could perform random spot checks from time to time to ensure ICT code is meeting expectations for maintainability, documentation, readability, and testability. The review role of the architects is then restricted to design reviews. This makes sense because one goal of our ICT architects is to ensure we are designing solutions that are consistent, in keeping with our stated architecture direction (e.g. web services), and perform well. |
